Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.15.0 #1445

Merged
merged 204 commits into from
Oct 17, 2019
Merged

Release v1.15.0 #1445

merged 204 commits into from
Oct 17, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 14, 2019

Release for Gutenberg Mobile v1.15.0

Related PRs:

To test:

  • Please test the WPiOS and WPAndroid PRs following their test steps.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@mchowning
Copy link
Contributor

We want to target master, right?

@etoledom etoledom changed the base branch from develop to master October 14, 2019 19:01
@etoledom
Copy link
Contributor Author

We want to target master, right?

Absolutely 😁

hypest and others added 4 commits October 16, 2019 12:46
WPAndroid updating to Gradle 5.4.1 caused a build failure when
BUILD_GUTENBERG_FROM_SOURCE was set to true because the
react-native-gutenberg-bridge could not access the WordPressUtils. In
particular, the WPAndroidGlueCode class would fail to import
org.wordpress.android.util.AppLog, causing a compilation error.
Switching WordPressUtils from an implementation dependency to an api
dependency in react-native-aztec resolves this problem.
* Fix issue when force Touch app shortcut doesn't work properly selecting "New Photo Post" on iOS
* Add Link Target (Open in new tab) to Image Block.
* [iOS] DarkMode improvements.
* [iOS] Update to iOS 11 and Swift 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this "[Platform] changes" format for platform-specific changes. I think I'll use this format going forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about [iOS] Update to iOS 11 and Swift 5, since it's not an user facing change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that is a fair point. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context on why I added it: since we also add some notes to the GitHub Release of the library itself, I figured that such upgrade is important to mention there. And indeed, it's not user facing so, happy it didn't reach the release-notes in the main app.

Maybe we can starting thinking of a way to denote this kind of "news" that are important/non-trivial for the library but not useful to bubble up to the main apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. If you look at core releases, there's often the news for users, and then a section of changes for developers.

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@mchowning mchowning merged commit faf9460 into master Oct 17, 2019
@mchowning mchowning deleted the release/1.15.0 branch October 17, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.