-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.15.0 #1445
Release v1.15.0 #1445
Conversation
# Conflicts: # gutenberg
Merge master (v1.13.0) back to develop
…e into feature/move-media-upload-progress
We want to target |
Absolutely 😁 |
WPAndroid updating to Gradle 5.4.1 caused a build failure when BUILD_GUTENBERG_FROM_SOURCE was set to true because the react-native-gutenberg-bridge could not access the WordPressUtils. In particular, the WPAndroidGlueCode class would fail to import org.wordpress.android.util.AppLog, causing a compilation error. Switching WordPressUtils from an implementation dependency to an api dependency in react-native-aztec resolves this problem.
* Fix issue when force Touch app shortcut doesn't work properly selecting "New Photo Post" on iOS | ||
* Add Link Target (Open in new tab) to Image Block. | ||
* [iOS] DarkMode improvements. | ||
* [iOS] Update to iOS 11 and Swift 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this "[Platform] changes" format for platform-specific changes. I think I'll use this format going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about [iOS] Update to iOS 11 and Swift 5
, since it's not an user facing change
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that is a fair point. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some context on why I added it: since we also add some notes to the GitHub Release of the library itself, I figured that such upgrade is important to mention there. And indeed, it's not user facing so, happy it didn't reach the release-notes in the main app.
Maybe we can starting thinking of a way to denote this kind of "news" that are important/non-trivial for the library but not useful to bubble up to the main apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea. If you look at core releases, there's often the news for users, and then a section of changes for developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release for Gutenberg Mobile v1.15.0
Related PRs:
To test:
Update release notes:
RELEASE-NOTES.txt
.